fix(start): skip signal forwarding in watch mode#3338
Merged
kamilmysliwiec merged 1 commit intonestjs:masterfrom Apr 9, 2026
Merged
fix(start): skip signal forwarding in watch mode#3338kamilmysliwiec merged 1 commit intonestjs:masterfrom
kamilmysliwiec merged 1 commit intonestjs:masterfrom
Conversation
the signal forwarding added for graceful shutdown caused watch mode to require double ctrl+c to exit. signal handlers are now only registered in non-watch mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
[x] Bugfix
What is the current behavior?
After #3313 (fix for async shutdown hooks), watch mode (
nest start --watch) requires pressing CTRL+C twice to exit. The signal forwarding handlers keep the parent process alive waiting for the child to exit, but in watch mode the watcher restarts the child, preventing clean termination.Reported by @johaven in #3158.
Issue Number: #3158
What is the new behavior?
Signal forwarding (SIGINT/SIGTERM) is now only registered in non-watch mode. In watch mode, the original behavior is preserved — CTRL+C immediately terminates via the
exithandler andtreeKillSync.Does this PR introduce a breaking change?
[ ] Yes
[x] No
Other information
nest start)treeKillSyncon exit as before