Explicitly allow null into CompletableResultCode.failExceptionally()#6963
Merged
jack-berg merged 3 commits intoopen-telemetry:mainfrom Dec 19, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6963 +/- ##
=========================================
Coverage 90.10% 90.10%
Complexity 6601 6601
=========================================
Files 730 730
Lines 19843 19843
Branches 1955 1955
=========================================
Hits 17879 17879
- Misses 1369 1370 +1
+ Partials 595 594 -1 ☔ View full report in Codecov by Sentry. |
jack-berg
reviewed
Dec 18, 2024
jack-berg
approved these changes
Dec 18, 2024
jkwatson
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to this comment: open-telemetry/opentelemetry-android#709 (comment)
This is useful when chaining result codes and wanting to not lose an existing throwable. It was completely valid before, but it wasn't documented.