Merged
Conversation
ai
reviewed
Jan 21, 2020
ai
reviewed
Jan 21, 2020
ai
reviewed
Jan 24, 2020
ai
reviewed
Jan 24, 2020
Member
|
Great work! Do you have Twitter handle to mention you on our Twitter? |
ai
pushed a commit
that referenced
this pull request
Jan 27, 2020
* fix circular dependencies * move to static methods to fix imports * remove default import from terminal highlight
Contributor
Author
|
Thanks! Yes. Brand new account actually, getting ready to launch this new initiative: @mapgridorg |
ai
pushed a commit
that referenced
this pull request
Feb 8, 2020
* fix circular dependencies * move to static methods to fix imports * remove default import from terminal highlight
ai
pushed a commit
that referenced
this pull request
Mar 28, 2020
* fix circular dependencies * move to static methods to fix imports * remove default import from terminal highlight
ai
pushed a commit
that referenced
this pull request
Mar 30, 2020
* fix circular dependencies * move to static methods to fix imports * remove default import from terminal highlight
ai
pushed a commit
that referenced
this pull request
Apr 8, 2020
* fix circular dependencies * move to static methods to fix imports * remove default import from terminal highlight
ai
pushed a commit
that referenced
this pull request
May 4, 2020
* fix circular dependencies * move to static methods to fix imports * remove default import from terminal highlight
ai
pushed a commit
that referenced
this pull request
May 29, 2020
* fix circular dependencies * move to static methods to fix imports * remove default import from terminal highlight
ai
pushed a commit
that referenced
this pull request
Jun 2, 2020
* fix circular dependencies * move to static methods to fix imports * remove default import from terminal highlight
ai
pushed a commit
that referenced
this pull request
Jun 21, 2020
* fix circular dependencies * move to static methods to fix imports * remove default import from terminal highlight
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While building a recent project with Rollup, we ran in to issues with circular dependencies in PostCSS. This PR solves circular dependencies across 3 files, and adds consistency to how files are included.
A sampling of current circular dependencies
container.jsIn
container.jsthere are 3 late-stylerequirein thenormalizefunction. This PR removes therequirecompletely and replaces it with a register dependency pattern.root.jsIn
root.jsthere are 2 late-stylerequirein thetoResultfunction. This PR removes therequirecompletely and replaces it with a register dependency pattern.terminal-highlight.es6In
terminal-highlight.jsthere is 1 late-stylerequirein theterminalHighlightfunction. This PR removes therequirecompletely and replaces it with a register dependency pattern.Improvement
requirestatements removed