Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #591.
Fixes #592.
Original ideas extracted from #592.
Add flat recommended config file. Unlike the legacy recommended file this only enables the prettier rule and disables
arrow-body-styleandarrow-body-style. It does not enable anything fromeslint-config-prettier.It is now the responsibility of the consumer to enable both
eslint-plugin-prettierandeslint-config-prettier. Configs extending other configs is complicated and not transparent. We should trust the user to configure their configs directly. In a future major change we should removeeslint-config-prettierfrom the legacy config too, as over lap between the responsibilities ofeslint-plugin-prettierandeslint-config-prettierhave always been a bit confusing and "a plugin goes and enables configs from other plugins" feels a bit odd. I think it is simpler if we push consumers towards "you configure both eslint-plugin-prettier and eslint-config-prettier in your repo's linting config.Use it like this: