Skip to content

Copy FieldInfo instance if necessary during FieldInfo build#11980

Merged
Viicos merged 1 commit intov2.11-fixesfrom
copy-default-fieldinfo
Jun 13, 2025
Merged

Copy FieldInfo instance if necessary during FieldInfo build#11980
Viicos merged 1 commit intov2.11-fixesfrom
copy-default-fieldinfo

Conversation

@Viicos
Copy link
Copy Markdown
Member

@Viicos Viicos commented Jun 13, 2025 •
edited
Loading

Change Summary

2.11 fix for #11978.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label Jun 13, 2025
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jun 13, 2025 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c3cad6b
Status: ✅  Deploy successful!
Preview URL: https://55c3e377.pydantic-docs.pages.dev
Branch Preview URL: https://copy-default-fieldinfo.pydantic-docs.pages.dev

View logs

@Viicos Viicos added the third-party-tests Add this label on a PR to trigger 3rd party tests label Jun 13, 2025
@Viicos Viicos closed this Jun 13, 2025
@Viicos Viicos reopened this Jun 13, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 13, 2025 •
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 13, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #11980 will improve performances by 6.2%

Comparing copy-default-fieldinfo (74ec5d5) with main (638d047)

Summary

⚡ 2 improvements
✅ 44 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ test_efficiency_with_highly_nested_examples 731.8 µs 690.8 µs +5.94%
⚡ test_north_star_validate_python_strict 24 ms 22.6 ms +6.2%

@Viicos Viicos force-pushed the copy-default-fieldinfo branch from c3cad6b to 74ec5d5 Compare June 13, 2025 17:38
@Viicos Viicos removed the third-party-tests Add this label on a PR to trigger 3rd party tests label Jun 13, 2025
@Viicos Viicos merged commit c3368b8 into v2.11-fixes Jun 13, 2025
95 checks passed
@Viicos Viicos deleted the copy-default-fieldinfo branch June 13, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Viicos