⚡️ Speed up to_snake() by 27% in pydantic/alias_generators.py#9747
Merged
sydney-runkle merged 6 commits intopydantic:mainfrom Jun 25, 2024
Merged
Conversation
To optimize the function, we can reduce the number of calls to `re.sub` and string replacement operations by performing all transformations in a single pass. Here's an optimized version of the `to_snake` function. ### Explanation of Optimizations. 1. **Single Regular Expression**: The `re.sub` function now takes a compiled regular expression that matches all the cases we care about for the transformations, including hyphens. This reduces the multiple passes over the string to a single pass. 2. **Single Pass Replacement**: By combining the conditions into a single regular expression, we achieve all transformations in one pass, leading to improved performance. This approach reduces the overhead of multiple function calls and iterations over the input string, making the function more efficient.
CodSpeed Performance ReportMerging #9747 will not alter performanceComparing Summary
|
sydney-runkle
approved these changes
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
📄
to_snake()inpydantic/alias_generators.py📈 Performance improved by
27%(0.27xfaster)⏱️ Runtime went down from
472 microsecondsto371 microsecondsExplanation and details
To optimize the function, we can reduce the number of calls to
re.suband string replacement operations by performing all transformations in a single pass. Here's an optimized version of theto_snakefunction.Explanation of Optimizations.
re.subfunction now takes a compiled regular expression that matches all the cases we care about for the transformations, including hyphens. This reduces the multiple passes over the string to a single pass.This approach reduces the overhead of multiple function calls and iterations over the input string, making the function more efficient.
Correctness verification
The new optimized code was tested for correctness. The results are listed below.
✅ 180 Passed − ⚙️ Existing Unit Tests
(click to show existing tests)
✅ 60 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
🔘 (none found) − ⏪ Replay Tests
This optimization was automatically discovered by codeflash.ai
Checklist