feat: add a key argument to SpecifierSet.filter()#1068
Merged
Conversation
Close pypa#1066 Signed-off-by: Frost Ming <[email protected]>
6641730 to
104ebf9
Compare
…lasses Signed-off-by: Frost Ming <[email protected]>
104ebf9 to
dc58940
Compare
henryiii
reviewed
Jan 23, 2026
henryiii
approved these changes
Jan 23, 2026
Contributor
henryiii
left a comment
There was a problem hiding this comment.
I think the TYPE_CHECKING should be removed, overloads just get replaced at runtime anyway, but otherwise looks good to me, nicely typed.
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Contributor
|
I pushed a minor stylistic change to better match some other code. |
henryiii
reviewed
Jan 23, 2026
…methods Signed-off-by: Frost Ming <[email protected]>
notatallshaw
approved these changes
Jan 23, 2026
Member
notatallshaw
left a comment
There was a problem hiding this comment.
Looks great!
It's annoying that type hinters don't validate the overload signatures against the body of the actual method. But this is the best way to represent the type signature.
This was referenced Apr 13, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1066
Signed-off-by: Frost Ming [email protected]