Conversation
|
/cc @brettcannon |
699543d to
77ce285
Compare
f52e9cf to
9112d47
Compare
| continue | ||
|
|
||
| # #. If :ref:`pylock-packages-requires-python` is specified, check if it is | ||
| # satisfied; an error MUST be raised if it isn't. |
There was a problem hiding this comment.
@brettcannon why is it an error if a package requires-python is not satisfied? Should it not be skipped in that case?
There was a problem hiding this comment.
That's for when https://packaging.python.org/en/latest/specifications/pylock-toml/#requires-python has been satisfied but somehow a specific package claims otherwise. When I wrote that I'm sure my brain was assuming requires-python would be set if packages.requires-python was set.
3382cf2 to
110467f
Compare
|
Except for the wheel file name discovery and validation mechanism (waiting for #1095) this should be complete and ready for review. |
5eeca07 to
ff14bd4
Compare
7891b69 to
a0256b2
Compare
|
I tweaked the |
|
@sbidoul is there some other PR you want to see merged, or are you ready for me to merge this? |
@brettcannon as you prefer. If #1110 is merged first I'll update this one. If this one is merged first then I'll do another PR to use the selector when #1110 is merged. |
399be36 to
9f20a3c
Compare
|
And I integrated the compatible tags selector. In 9f20a3c I relaxed the typing of So all is done and clean here, I think. The only bits that I don't like are the type casts around Environment, but I couldn't find a way to please mypy. |
|
And a test had to be updated following the stricter validation in #1114. |
|
@sbidoul thanks so much for working on this! Hopefully this helps unblock pip from installing from a lock file. |
|
That was fun. I'll now see what I can do in pip. That might be a bit more hairy. |
Co-authored-by: Brett Cannon <[email protected]>
This is WIP. Main missing part is handling of dependency groups and extras. And tests of course.Comments are from PEP 751 Installation section.
closes #1087