Use direct operator methods in _compare_compatible#1100
Merged
notatallshaw merged 1 commit intopypa:mainfrom Feb 28, 2026
Merged
Use direct operator methods in _compare_compatible#1100notatallshaw merged 1 commit intopypa:mainfrom
_compare_compatible#1100notatallshaw merged 1 commit intopypa:mainfrom
Conversation
henryiii
approved these changes
Feb 28, 2026
ngoldbaum
pushed a commit
to ngoldbaum/packaging
that referenced
this pull request
Apr 1, 2026
This was referenced Apr 13, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already use direct operator method calls in other places now, this makes it easier to navigate the code using coding tools as you can jump directly to the intended method.
And in theory should be slight faster, as you don't have to go via another function to get the correct method, but I have not benchmarked it and I imagine it would be marginal.
I have added additional parenthesis to preserve the method calls on a single line, otherwise formatting breaks them up.