Skip to content

feat: direct_url#944

Merged
henryiii merged 5 commits intopypa:mainfrom
sbidoul:direct_url-sbi
Mar 23, 2026
Merged

feat: direct_url#944
henryiii merged 5 commits intopypa:mainfrom
sbidoul:direct_url-sbi

Conversation

@sbidoul
Copy link
Copy Markdown
Member

@sbidoul sbidoul commented Oct 12, 2025

I'm opening this to show what direct_url.json support could look like, in the same style as what I did for pylock in #900.

If maintainers agree with the approach, I'll be happy to move this forward.

Towards #701.

@sbidoul sbidoul marked this pull request as draft October 12, 2025 13:17
@brettcannon
Copy link
Copy Markdown
Member

brettcannon commented Oct 31, 2025

I'm fine with the approach. Not sure if there's anything to borrow/share with packaging.pylock since similar data is in both specs (by design).

@pradyunsg @henryiii @notatallshaw any opinions?

@sbidoul sbidoul force-pushed the direct_url-sbi branch 3 times, most recently from 941c15c to c6e7e4a Compare November 8, 2025 13:48
@brettcannon brettcannon mentioned this pull request Feb 9, 2026
Open
@sbidoul sbidoul marked this pull request as ready for review February 21, 2026 18:38
@sbidoul sbidoul changed the title [DRAFT] direct_url direct_url Feb 21, 2026
@sbidoul sbidoul mentioned this pull request Feb 22, 2026
Open
@sbidoul sbidoul force-pushed the direct_url-sbi branch 3 times, most recently from ca29d5e to 74d09a2 Compare February 22, 2026 13:52
@sbidoul
Copy link
Copy Markdown
Member Author

sbidoul commented Feb 22, 2026 •
edited
Loading

Not sure if there's anything to borrow/share with packaging.pylock since similar data is in both specs (by design).

I don't think so. The concepts are close, but the data structures are different.

This is now complete and ready for review.

henryiii
henryiii reviewed Feb 23, 2026
View reviewed changes
Comment thread docs/direct_url.rst Outdated
Comment thread src/packaging/direct_url.py
Comment thread src/packaging/direct_url.py Outdated
Comment thread src/packaging/direct_url.py Outdated
Comment thread src/packaging/direct_url.py
@henryiii henryiii changed the title direct_url feat: direct_url Feb 23, 2026
@henryiii henryiii force-pushed the direct_url-sbi branch 2 times, most recently from b85e3fa to 8513b55 Compare March 6, 2026 16:09
@henryiii henryiii merged commit c4d2b3a into pypa:main Mar 23, 2026
56 checks passed
@sbidoul sbidoul deleted the direct_url-sbi branch March 23, 2026 21:02
@sbidoul
Copy link
Copy Markdown
Member Author

sbidoul commented Mar 23, 2026

Thanks for the review and merge @henryiii !

ngoldbaum pushed a commit to ngoldbaum/packaging that referenced this pull request Apr 1, 2026
@sbidoul @ngoldbaum
feat: direct_url (pypa#944)
0ae5c1c 
* Add direct_url model and validator

* direct_url: better handling of legacy hashes

* direct_url: strip url in to_dict

* direct_url: add docs

* direct_url: handle review comments
This was referenced Apr 13, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henryiii henryiii henryiii approved these changes

+1 more reviewer

@sirosen sirosen sirosen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sbidoul @brettcannon @sirosen @henryiii