Merged
Conversation
Member
Author
|
@jeremyevans @simi I think once this is merged, #2210 will be green. |
jeremyevans
approved these changes
Jun 17, 2024
Member
Author
|
@jeremyevans if this is breaking Sinatra, I'd like to backport, as our interpretation of the RFC was incorrect, so this should be a bug. |
Contributor
|
Backporting to 3.1 is fine. |
simi
pushed a commit
to RubyElders/rack
that referenced
this pull request
Jun 17, 2024
dentarg
pushed a commit
to dentarg/rack
that referenced
this pull request
Jul 10, 2024
This was referenced Jul 10, 2024
ioquatix
added a commit
that referenced
this pull request
Jul 11, 2024
Co-authored-by: Samuel Williams <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From https://datatracker.ietf.org/doc/html/rfc3875#section-4.1.5:
The PATH_INFO variable specifies a path to be interpreted by the CGI
script. It identifies the resource or sub-resource to be returned by
the CGI script, and is derived from the portion of the URI path
hierarchy following the part that identifies the script itself.
Unlike a URI path, the PATH_INFO is not URL-encoded, and cannot
contain path-segment parameters. A PATH_INFO of "/" represents a
single void path segment.
Our interpretation of
PATH_INFOis more extensive than the CGI specification to allow for things likeOPTIONS *andCONNECT host:portstyle requests.