Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades various packages across the project to their latest versions, including major updates to React from v18 to v19 and TypeScript from 5.4.5 to 5.9.2. The changes also modernize SCSS syntax and refactor deprecated Node.js module imports.
- Upgrade React and React types from v18 to v19 across all packages
- Update TypeScript, ESLint, and various build tools to latest versions
- Modernize SCSS syntax from @import to @use statements and update map function calls
- Refactor deprecated Node.js child_process import pattern
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/ts-test/package.json | Updates React/TypeScript dependencies to latest versions |
| packages/react-icons/src/iconBase.tsx | Changes return type from JSX.Element to React.ReactElement |
| packages/react-icons/scripts/task_common.ts | Refactors child_process import to use explicit import |
| packages/react-icons/scripts/logics.ts | Updates cheerio imports and type references |
| packages/react-icons/package.json | Upgrades dev dependencies including Babel, TypeScript, and build tools |
| packages/preview-astro/src/styles/global.scss | Converts @import to @use statements |
| packages/preview-astro/src/styles/_utils.scss | Adds sass:map import and updates map function syntax |
| packages/preview-astro/src/styles/_components.scss | Updates import syntax and namespaces function calls |
| packages/preview-astro/package.json | Upgrades Astro, React, and Sass dependencies |
| packages/demo/package.json | Updates React dependencies to v19 |
| packages/demo-all-files/package.json | Updates React dependencies to v19 |
| package.json | Upgrades ESLint, TypeScript, and other dev dependencies |
| eslint.config.cjs | Adds CommonJS configuration and ignores Astro build directory |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| load as cheerioLoad, | ||
| Element as CheerioElement, | ||
| } from "cheerio"; | ||
| import { Cheerio, load as cheerioLoad } from "cheerio"; |
There was a problem hiding this comment.
The type import should use the 'import type' syntax consistently. Consider using 'import type { Cheerio }' as well since Cheerio appears to be used only as a type in this context.
Suggested change
| import { Cheerio, load as cheerioLoad } from "cheerio"; | |
| import { load as cheerioLoad } from "cheerio"; | |
| import type { Cheerio } from "cheerio"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.