Override refractor 3.6.0's prismjs dependency#605
Merged
Conversation
refractor 3.6.0refractor 3.6.0's prismjs dependency
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #605 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 11 11
Lines 327 327
Branches 130 130
=======================================
Hits 314 314
Misses 12 12
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Aug 25, 2025
Closed
Closed
lodinukal
pushed a commit
to lodinukal/react-syntax-highlighter
that referenced
this pull request
Aug 26, 2025
…ighter#605) * override refractor 3.6.0's prismjs dependency * rebuild demos
lodinukal
pushed a commit
to lodinukal/react-syntax-highlighter
that referenced
this pull request
Aug 26, 2025
…ighter#605) * override refractor 3.6.0's prismjs dependency * rebuild demos
lodinukal
pushed a commit
to lodinukal/react-syntax-highlighter
that referenced
this pull request
Aug 26, 2025
…ighter#605) * override refractor 3.6.0's prismjs dependency * rebuild demos
This was referenced Sep 3, 2025
|
FYI this PR doesn't fix the issue - you only solved it for this repo, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating to
refractor4.x or 5.x introduces breaking changes forreact-syntax-highlighter(see #521 for example)A simpler fix for now is to use an npm override to ensure that the old version of
refractordoesn't bring in the vulnerable version ofprismjs.This is a followup to #599, where simply updating this project's
prismjsdep didn't take care of the vulnerable version being brought in as a transitive dep ofrefractor 3.6.0.