Skip to content

Fix polar angle axis ticks text positions#6276

Merged
ckifer merged 2 commits intorecharts:mainfrom
mindtraveller:main
Sep 5, 2025
Merged

Fix polar angle axis ticks text positions#6276
ckifer merged 2 commits intorecharts:mainfrom
mindtraveller:main

Conversation

@mindtraveller
Copy link
Copy Markdown
Contributor

@mindtraveller mindtraveller commented Sep 4, 2025

Description

Correctly set text vertical positions of polar angle axis.

Related Issue

#4747

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

before after
image image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a storybook story or VR test, or extended an existing story or VR test to show my changes

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.61%. Comparing base (e7828da) to head (7f4735a).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6276      +/-   ##
==========================================
- Coverage   96.63%   96.61%   -0.03%     
==========================================
  Files         221      221              
  Lines       20147    20157      +10     
  Branches     4129     4134       +5     
==========================================
+ Hits        19470    19475       +5     
- Misses        670      675       +5     
  Partials        7        7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PavelVanecek
Copy link
Copy Markdown
Collaborator

PavelVanecek commented Sep 4, 2025

There's some visual diff: https://github.com/recharts/recharts/actions/runs/17464175639/artifacts/3927876648 looks legit to me, can you please update the snapshots and commit those too?

@PavelVanecek
Copy link
Copy Markdown
Collaborator

PavelVanecek commented Sep 4, 2025 •
edited
Loading

This is the storybook diff: https://www.chromatic.com/build?appId=63da8268a0da9970db6992aa&number=2750

28 changes, looks like improvement to me. Thanks for the fix, let's merge this once the screenshots are up to date

ckifer
ckifer approved these changes Sep 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ckifer ckifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, will merge when the Vr tests are updated

@mindtraveller
Copy link
Copy Markdown
Contributor Author

mindtraveller commented Sep 5, 2025

how do I update all the snapshots? I only found test-vr:update command, but not sure that's enough

@PavelVanecek
Copy link
Copy Markdown
Collaborator

PavelVanecek commented Sep 5, 2025

That should do it yes

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 5, 2025

Bundle Report

Changes will increase total bundle size by 1.45kB (0.06%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
recharts/bundle-cjs 1.04MB 690 bytes (0.07%) ⬆️
recharts/bundle-es6 894.21kB 638 bytes (0.07%) ⬆️
recharts/bundle-umd 485.77kB 118 bytes (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: recharts/bundle-umd

Assets Changed:

Asset Name Size Change Total Size Change (%)
Recharts.js 118 bytes 485.77kB 0.02%
view changes for bundle: recharts/bundle-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
polar/PolarAngleAxis.js 651 bytes 11.83kB 5.82% ⚠️
state/store.js 39 bytes 3.05kB 1.29%
view changes for bundle: recharts/bundle-es6

Assets Changed:

Asset Name Size Change Total Size Change (%)
polar/PolarAngleAxis.js 599 bytes 10.51kB 6.05% ⚠️
state/store.js 39 bytes 2.59kB 1.53%

@ckifer ckifer merged commit 90665de into recharts:main Sep 5, 2025
20 of 21 checks passed
@PavelVanecek PavelVanecek mentioned this pull request Nov 10, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PavelVanecek PavelVanecek PavelVanecek approved these changes

@ckifer ckifer ckifer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mindtraveller @PavelVanecek @ckifer