Skip to content

Add docs and tests for Text component#6278

Merged
PavelVanecek merged 3 commits intomainfrom
text-tests
Sep 5, 2025
Merged

Add docs and tests for Text component#6278
PavelVanecek merged 3 commits intomainfrom
text-tests

Conversation

@PavelVanecek
Copy link
Copy Markdown
Collaborator

@PavelVanecek PavelVanecek commented Sep 4, 2025 •
edited
Loading

I think there is a bug where vertical position is calculated wrong when scaleToFit is set.

I tried to reproduce #6190 but couldn't.

Copilot AI review requested due to automatic review settings September 4, 2025 14:25
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.61%. Comparing base (341f4ae) to head (794345c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6278   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files         221      221           
  Lines       20147    20157   +10     
  Branches     4130     4134    +4     
=======================================
+ Hits        19465    19475   +10     
  Misses        675      675           
  Partials        7        7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 4, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 1.42kB (0.06%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
recharts/bundle-cjs 1.04MB 651 bytes (0.06%) ⬆️
recharts/bundle-es6 894.21kB 599 bytes (0.07%) ⬆️
recharts/bundle-umd 485.77kB 169 bytes (0.03%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: recharts/bundle-umd

Assets Changed:

Asset Name Size Change Total Size Change (%)
Recharts.js 169 bytes 485.77kB 0.03%
view changes for bundle: recharts/bundle-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
polar/PolarAngleAxis.js 651 bytes 11.83kB 5.82% ⚠️
view changes for bundle: recharts/bundle-es6

Assets Changed:

Asset Name Size Change Total Size Change (%)
polar/PolarAngleAxis.js 599 bytes 10.51kB 6.05% ⚠️

Copilot AI reviewed Sep 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 4, 2025

Visual Regression tests failed.

@PavelVanecek
Copy link
Copy Markdown
Collaborator Author

PavelVanecek commented Sep 4, 2025

Sigh different font on the screenshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 4, 2025

Visual Regression tests failed.

ckifer
ckifer approved these changes Sep 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ckifer ckifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but looks like maybe some flaky VR stuff going on?

@PavelVanecek PavelVanecek merged commit 9ffd7c8 into main Sep 5, 2025
25 of 27 checks passed
@PavelVanecek PavelVanecek deleted the text-tests branch September 5, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ckifer ckifer ckifer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PavelVanecek @ckifer