Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.44%. Comparing base (b88328a) to head (7640e87).
⚠️ Report is 6 commits behind head on main.

@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage   97.43%   97.44%           
=======================================
  Files          20       20           
  Lines        4101     4104    +3     
=======================================
+ Hits         3996     3999    +3     
  Misses        105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

IMO it'd be nice to wait for conclusive end to end confirmation this is the last bit of tweaking needed for the OP that kicked off this work before we publish another release.

That was my plan exactly!

@sgrams ping? Any thoughts?

I was able to populate RequiredEkuNotFoundContext::present without the need of this commit.

I was able to populate RequiredEkuNotFoundContext::present without the need of this commit.

How did you write it?

@ctz @cpu should we still take this?

@ctz @cpu should we still take this?

It's small enough I have no strong opinions.

I was able to populate RequiredEkuNotFoundContext::present without the need of this commit.

I think I tracked down the code where you did that, and unfortunately it's not correct. I think you really do want this PR instead.

To expand: if you round-trip your EKU_SPDM_REQUESTER_AUTH (ie. 1.3.6.1.4.1.412.274.4) through your code, it will get printed as 43.6.1.4.1.131.28.130.18.4