fix: improve Clone function to preserve nilness and avoid liveness issues#740
Merged
samber merged 1 commit intosamber:masterfrom Nov 7, 2025
Merged
fix: improve Clone function to preserve nilness and avoid liveness issues#740samber merged 1 commit intosamber:masterfrom
samber merged 1 commit intosamber:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #740 +/- ##
==========================================
- Coverage 94.04% 94.01% -0.04%
==========================================
Files 18 18
Lines 2838 2840 +2
==========================================
+ Hits 2669 2670 +1
- Misses 152 153 +1
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the implementation of the
Clonefunction inslice.goto improve its behavior and future compatibility. The main change is a safer cloning approach that avoids potential issues with slice liveness and preserves nilness, aligning with improvements in Go 1.21.Improvements to slice cloning:
Clonefunction to avoid usingcollection[:0:0], which could cause unwanted liveness when cloning zero-length slices of large arrays. The new implementation usesappend(Slice{}, collection...)for safer cloning.slices.Clonein Go 1.21 and can be replaced once support for Go 1.20 is dropped.