Skip to content

Test refactoring#223

Merged
elacuesta merged 9 commits intomainfrom
test-refactoring
Aug 16, 2023
Merged

Test refactoring#223
elacuesta merged 9 commits intomainfrom
test-refactoring

Conversation

@elacuesta
Copy link
Copy Markdown
Member

@elacuesta elacuesta commented Aug 16, 2023

  1. Updated tests to use the most recent versions of pytest plugins (previously not working with pytest-asyncio>=0.11)
  2. Split asyncio/twisted tests, they don't play well together
  3. Bump minimum Python version to 3.8, to use unittest.IsolatedAsyncioTestCase (py37 is EOL anyway)
  4. Pinned playwright==1.36.0 in tests, playwright==1.37.0 fails for some reason

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 16, 2023

Codecov Report

Merging #223 (f280f4f) into main (1c3f425) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #223   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          388       388           
=========================================
  Hits           388       388           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elacuesta elacuesta marked this pull request as ready for review August 16, 2023 02:49
@elacuesta elacuesta merged commit e0f3b61 into main Aug 16, 2023
@elacuesta elacuesta deleted the test-refactoring branch August 16, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant