Skip to content

Handle downloads as binary responses#228

Merged
elacuesta merged 14 commits intomainfrom
handle-downloads
Oct 19, 2023
Merged

Handle downloads as binary responses#228
elacuesta merged 14 commits intomainfrom
handle-downloads

Conversation

@elacuesta
Copy link
Copy Markdown
Member

@elacuesta elacuesta commented Sep 6, 2023

Return the binary contents in the response body for requests that only trigger a download.
Closes #184

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 6, 2023

Codecov Report

Merging #228 (57a8192) into main (a1618db) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #228   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          410       442   +32     
=========================================
+ Hits           410       442   +32     
Files Changed Coverage Δ
scrapy_playwright/handler.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elacuesta elacuesta marked this pull request as ready for review September 8, 2023 18:42
@elacuesta elacuesta merged commit 0140b90 into main Oct 19, 2023
@elacuesta elacuesta deleted the handle-downloads branch October 19, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handling of binary files

1 participant