Skip to content

Custom memusage extension#257

Merged
elacuesta merged 13 commits intomainfrom
custom-memusage-extension
Jan 1, 2024
Merged

Custom memusage extension#257
elacuesta merged 13 commits intomainfrom
custom-memusage-extension

Conversation

@elacuesta
Copy link
Copy Markdown
Member

@elacuesta elacuesta commented Dec 28, 2023

A replacement memusage extension that inspects the Playwright processes to get accurate memory usage. Originally requested at #40

Tasks:

  • Code
  • Tests
  • Docs

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6156f70) 100.00% compared to head (81e5512) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #257   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines          448       489   +41     
=========================================
+ Hits           448       489   +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elacuesta elacuesta marked this pull request as ready for review December 28, 2023 22:49
Copy link
Copy Markdown
Contributor

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

PS: An addon is starting to look worth considering 🙂

@elacuesta
Copy link
Copy Markdown
Member Author

Thanks. I must admit I'm not overly familiar with the addon system just yet, I'll take a look next year 😉 .

@elacuesta elacuesta merged commit 05f1d66 into main Jan 1, 2024
@elacuesta elacuesta deleted the custom-memusage-extension branch January 1, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants