Skip to content

Connect to remote browser using BrowserType.connect#283

Merged
elacuesta merged 12 commits intomainfrom
connect-over-websocket
Jul 6, 2024
Merged

Connect to remote browser using BrowserType.connect#283
elacuesta merged 12 commits intomainfrom
connect-over-websocket

Conversation

@elacuesta
Copy link
Copy Markdown
Member

@elacuesta elacuesta commented Jul 1, 2024

Closes #277

Allow to connect to a remote browser with BrowserType.connect.

Introduces two new settings:

  • PLAYWRIGHT_CONNECT_URL: Optional[str], default None
  • PLAYWRIGHT_CONNECT_KWARGS: dict[str, Any], default {}

@elacuesta elacuesta added the enhancement New feature or request label Jul 1, 2024
@elacuesta elacuesta added this to the v0.0.37 milestone Jul 1, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d825d6f) to head (2fc8fba).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #283   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          546       561   +15     
=========================================
+ Hits           546       561   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elacuesta elacuesta marked this pull request as ready for review July 2, 2024 13:36
@elacuesta elacuesta modified the milestones: v0.0.39, v0.0.38 Jul 6, 2024
@elacuesta elacuesta merged commit 8c6d9bb into main Jul 6, 2024
@elacuesta elacuesta deleted the connect-over-websocket branch July 6, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scrapy-playwright connect to remote firefox instance

1 participant