Merged
Conversation
maraino
requested changes
Feb 4, 2025
Contributor
maraino
left a comment
There was a problem hiding this comment.
I'm still working on this, but here's part of it.
maraino
requested changes
Feb 4, 2025
maraino
reviewed
Feb 6, 2025
Contributor
maraino
left a comment
There was a problem hiding this comment.
Looks good to me, I've just added a few comments, mostly clarifications that you can add as comments, and we should provide docs about how to set up the environment to re-generate the columns.go if we need to.
maraino
approved these changes
Feb 6, 2025
The nssdb package can read and write certificates, public keys, and private keys in NSS sqlite databases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nssdb package can read and write certificates, public keys, and private keys in NSS sqlite databases.
Name of feature:
NSS database
Pain or issue this feature alleviates:
Add certificates to NSS without pk12util.
In what environments or workflows is this feature supported?
Only certificates with EC P-256 keys are supported.
💔Thank you!