Conversation
This allows the uploads to finish without mismatched Content-Length, likely because the original method implied a wrong body encoding or something similar. Unfortunately a GitHub server API mock was not readily available so I had to test manually with a barebones repository. Fixes: softprops#555 Fixes: softprops#556 Signed-off-by: WANG Xuerui <[email protected]>
Signed-off-by: WANG Xuerui <[email protected]>
Signed-off-by: WANG Xuerui <[email protected]>
Signed-off-by: WANG Xuerui <[email protected]>
|
Thanks for the fix! |
…2.0" This reverts commit 15f61ca. There's a bug in softprops 'action-gh-release' action which appears when uploading larger assets. Reverting to an earlier version until fix is merged. Ref: softprops/action-gh-release#562 Ref: softprops/action-gh-release#556 Signed-off-by: JP-Ellis <[email protected]>
…2.0" This reverts commit 15f61ca. There's a bug in softprops 'action-gh-release' action which appears when uploading larger assets. Reverting to an earlier version until fix is merged. Ref: softprops/action-gh-release#562 Ref: softprops/action-gh-release#556 Signed-off-by: JP-Ellis <[email protected]>
|
Hi @softprops I've tested the PR and it worked for my case as reported in #552 (comment). |
Good to hear and Happy New Year 🎉! I would have to wait for either @softprops or @chenrui333 to make the release though... I'm new to the project so I don't have the permission to tag the release yet. (Or I would have merged this the day I submitted it.) |
|
@chenrui333 @softprops please assist with getting this merged Find lots of packages experiencing and tagging to 2.1.0 instead of latest due to this issue This is all work that will need undone once 2.2.1 is released |
|
@xen0n can you add changelog notes for the release of 2.2.1 advising users to not take that due to an error |
|
my bad, gonna release this change now. |
|
cut the new 2.2.1 release, thanks! |
|
Thanks heaps! |
Sorry for the broken 2.2.0 release, I've now tested this change with actual big file uploads at my testing ground repo with successful test run here.
@chenrui333: please tag a 2.2.1 release after this, thanks!