Conversation
/**
* Get the number of elements in the JSONArray, included nulls.
*
* @return The length (or size).
*/
public int length() {
return this.myArrayList.size();
}given this, I can't see this change offering much except it increases memory be 1 int length and saves 2 derefrences. unless you are iterating over millions of items, I don't see this impacting performance at all |
|
This is a proposed performance improvement, not a bug fix or enhancement, and contains no behavior or API changes. This lowers the acceptance bar a bit. I have not looked at performance at all yet; I would think a number of potential improvements could be made.
Here is a discussion that might provide some insight into the change you are proposing: |
|
@stleary @johnjaylward Thanks for the feedback , i will get back u with another pull request ,with the changes, more concrete benchmarks quantification |
|
No further action at this time. |
No description provided.