Add constructor based initialization for CJS based TypeScript imports#2669
Merged
prathmesh-stripe merged 3 commits intomasterfrom Apr 8, 2026
Merged
Add constructor based initialization for CJS based TypeScript imports#2669prathmesh-stripe merged 3 commits intomasterfrom
prathmesh-stripe merged 3 commits intomasterfrom
Conversation
jar-stripe
reviewed
Apr 8, 2026
jar-stripe
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
CJS TypeScript users who write
import Stripe = require('stripe')get no type information fromStripeConstructorit's untyped, sonew Stripe()andStripe()both resolve toany. This makes the CJS TypeScript experience significantly worse than ESM, where full types are available.What?
StripeCallableConstructortype tostripe.cjs.node.tsandstripe.cjs.worker.tsthat intersectstypeof Stripe(construct signature + static members) with a call signature.new Stripe(key, config)andStripe(key, config)are fully typed for CJS TypeScript consumerstestProjects/cjs-ts/integration test project that validates CJS TypeScript usage: constructor patterns, static member access, instance members, error handling, andinstanceofcheckstestProjects/cjs/index.jstest to cover both callable andnewpatterns, static property access, andinstanceofchecksSee Also
#2660
Changelog
newkeyword is now possible for CJS based TypeScript project. Resolves: 2660