♻️ Rich Text - Table Plugin - Add mermaid button to unsupported table type#5205
Merged
♻️ Rich Text - Table Plugin - Add mermaid button to unsupported table type#5205
Conversation
🦋 Changeset detectedLatest commit: 859c5b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JackDevAU
reviewed
Oct 15, 2024
| @@ -59,6 +59,7 @@ export const unsupportedItemsInTable = new Set([ | |||
| 'Unordered List', | |||
Member
There was a problem hiding this comment.
I think we should change this at a later stage, I feel its going to be forgotten and someones going to change the label/tooltip of one of the buttons and this will break.
JackDevAU
approved these changes
Oct 15, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the mermaid button doesn't show up in the fixed-toolbar when a user is inside a table.
Figure: Mermaid button not shown when user is inside a table
Figure: Mermaid button shows up when user is outside a table