Docs: add Border radius section for Input group#40776
Merged
julien-deramond merged 5 commits intotwbs:mainfrom Apr 9, 2025
Merged
Docs: add Border radius section for Input group#40776julien-deramond merged 5 commits intotwbs:mainfrom
julien-deramond merged 5 commits intotwbs:mainfrom
Conversation
louismaximepiton
approved these changes
Aug 29, 2024
Member
louismaximepiton
left a comment
There was a problem hiding this comment.
I'm fine with the implementation, waiting for another review.
Member
|
I'm not opposed, but I'll push some edits to explain why this section is here. |
mdo
approved these changes
Apr 9, 2025
julien-deramond
approved these changes
Apr 9, 2025
Member
julien-deramond
left a comment
There was a problem hiding this comment.
Thanks for the collective work here 💪
Just used the .d-none class and refined some property values in e3d9b82
This was referenced Aug 19, 2025
This was referenced Aug 26, 2025
This was referenced Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added a Border radius section in the Input group docs to explicitly show how that style is applied to the children elements.
I might have given too much importance to the section because I wanted the behavior to be clear to newcomers and avoid any confusion, but I could see how the same information could be delivered just by adding a single line in the Basic example section.
Please let me know if there is anything I can improve with my solution.
Type of changes
Checklist
npm run lint)Live previews
Related issues
Closes #40763