Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully ports the no-func-assign rule from ESLint. The implementation is comprehensive, covering function declarations and named function expressions, and correctly handling shadowing. The addition of the IsWriteReference utility is a good, reusable component. The tests and documentation are also well-written. I've made a couple of suggestions to improve code readability and maintainability in the rule implementation. Overall, this is a solid contribution.
0e27473 to
47c28ba
Compare
199bee2 to
0316060
Compare
0316060 to
1ede901
Compare
1ede901 to
09d5101
Compare
Summary
Port the
no-func-assignrule from ESLint to rslint.Disallow reassigning function declarations
Related Links
Tracking issue: [Tracking]: eslint core rules #223
ESLint rule: https://eslint.org/docs/latest/rules/no-func-assign
Source code: https://github.com/eslint/eslint/blob/main/lib/rules/no-func-assign.js
Checklist