feat: pass rule settings into rule context#587
Merged
fansenze merged 3 commits intoweb-infra-dev:mainfrom Apr 1, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a Settings field to the linter's rule configuration and context, allowing rules to access global settings. Changes include updates to the ConfiguredRule and RuleContext structs, as well as the rule testing framework to support settings in test cases. Feedback suggests exporting the cloneSettings helper to avoid code duplication across api.go and rule_registry.go, optimizing the cloning logic by moving it outside of loops to reduce allocations, and ensuring that settings are correctly populated when converting ESLint test cases to maintain compatibility.
fansenze
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes a gap in internal/rule_tester where test case Settings were defined but never propagated to rule.RuleContext.
Related Links
Checklist