fix: add missing RequiresTypeInfo meta to 7 typescript-eslint rules#601
Merged
fix: add missing RequiresTypeInfo meta to 7 typescript-eslint rules#601
Conversation
The following rules use ctx.TypeChecker but were missing RequiresTypeInfo: true, which tells the linter to skip them on files without a type checker: - consistent-return - no-empty-interface - prefer-includes - prefer-readonly - prefer-regexp-exec - restrict-template-expressions - switch-exhaustiveness-check
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several TypeScript linting rules, including consistent-return, no-empty-interface, prefer-includes, prefer-readonly, prefer-regexp-exec, restrict-template-expressions, and switch-exhaustiveness-check, by setting the RequiresTypeInfo flag to true. This change ensures that these rules are correctly identified as requiring type information for their execution. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
7 @typescript-eslint rules use
ctx.TypeCheckerbut were missingRequiresTypeInfo: truein their rule metadata. Without this flag, the linter will run these rules on files without a type checker, which can cause panics or silent no-ops.Rules fixed:
consistent-returnno-empty-interfaceprefer-includesprefer-readonlyprefer-regexp-execrestrict-template-expressionsswitch-exhaustiveness-checkRelated Links
no-ex-assignnil checker guard)Checklist