fix: avoid false positives in ban-ts-comment#607
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the ban_ts_comment rule to use the TypeScript scanner via utils.ForEachComment instead of manual string parsing, ensuring that comment-like text within strings or template literals is correctly ignored. While the logic improvement is sound, several critical issues were identified regarding string offset handling. The current implementation incorrectly slices UTF-8 Go strings using UTF-16 offsets from the TypeScript shim, which will cause failures with non-ASCII characters. Furthermore, there are inconsistencies in bounds checking and diagnostic reporting due to mixing UTF-16 and byte-based units, and the availability of the ForEachComment utility needs to be verified.
fansenze
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Links
avoid false positives in ban-ts-comment, e.g const c = '// @ts-ignore'
Checklist