chore: run @rspack/cli, @rspack/tests tests sequentially in wasm#13557
chore: run @rspack/cli, @rspack/tests tests sequentially in wasm#13557
@rspack/cli, @rspack/tests tests sequentially in wasm#13557Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 573bf83b94
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Adds a debug hook to the reusable test workflow to help investigate WASM CI runs by invoking a tmate-based debugger action when the target is wasm32-wasip1-threads.
Changes:
- Add a “Debug WASM” step in the reusable test workflow for the WASM target.
- Invoke the repository’s
debuggercomposite action as part of the WASM test job.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Merging this PR will degrade performance by 4.11%
Performance Changes
Comparing Footnotes
|
📦 Binary Size-limit
🎉 Size decreased by 7.34KB from 49.09MB to 49.08MB (⬇️0.01%) |
This reverts commit c71dafe.
Pull request was converted to draft
c12abe5 to
d0f4255
Compare
Deploying rspack with
|
| Latest commit: |
d0f4255
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f2cf7c70.rspack-v2.pages.dev |
| Branch Preview URL: | https://03-31-chore-debug-wasm.rspack-v2.pages.dev |
d0f4255 to
ee6658a
Compare
@rspack/cli, @rspack/tests tests sequentially in wasm
Summary
I find that the flaky nearly goes if we sequentially runs two sets of tests (@rspack/cli, @rspack/tests).
The root cause neends further investigation.
Checklist