Skip to content

chore: run @rspack/cli, @rspack/tests tests sequentially in wasm#13557

Merged
CPunisher merged 4 commits intomainfrom
03-31-chore/debug-wasm
Apr 1, 2026
Merged

chore: run @rspack/cli, @rspack/tests tests sequentially in wasm#13557
CPunisher merged 4 commits intomainfrom
03-31-chore/debug-wasm

Conversation

@CPunisher
Copy link
Copy Markdown
Contributor

@CPunisher CPunisher commented Mar 31, 2026

Summary

I find that the flaky nearly goes if we sequentially runs two sets of tests (@rspack/cli, @rspack/tests).

The root cause neends further investigation.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CPunisher CPunisher changed the title chore: add debugger action chore: debug WASM CI Mar 31, 2026
@github-actions github-actions Bot added the team The issue/pr is created by the member of Rspack. label Mar 31, 2026
@CPunisher CPunisher marked this pull request as ready for review March 31, 2026 12:09
@CPunisher CPunisher requested a review from stormslowly as a code owner March 31, 2026 12:09
Copilot AI review requested due to automatic review settings March 31, 2026 12:09
@CPunisher CPunisher marked this pull request as draft March 31, 2026 12:09
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 573bf83b94

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/reusable-build-test.yml Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a debug hook to the reusable test workflow to help investigate WASM CI runs by invoking a tmate-based debugger action when the target is wasm32-wasip1-threads.

Changes:

  • Add a “Debug WASM” step in the reusable test workflow for the WASM target.
  • Invoke the repository’s debugger composite action as part of the WASM test job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/reusable-build-test.yml Outdated
Comment thread .github/workflows/reusable-build-test.yml Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 31, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB 0
react-1k 826.3 KB 0
react-5k 2.7 MB 0
rome 984.2 KB 0
ui-components 2.3 MB 0

Generated by Rsdoctor GitHub Action

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 31, 2026

Merging this PR will degrade performance by 4.11%

❌ 1 regressed benchmark
✅ 15 untouched benchmarks
⏩ 19 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation rust@create_chunk_ids 10.3 ms 10.8 ms -4.11%

Comparing 03-31-chore/debug-wasm (ee6658a) with main (19523a1)

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 31, 2026

📦 Binary Size-limit

Comparing ee6658a to refactor(split-chunks): reduce module group allocation churn (#13560) by harpsealjs

🎉 Size decreased by 7.34KB from 49.09MB to 49.08MB (⬇️0.01%)

@CPunisher CPunisher changed the title chore: debug WASM CI chore: enlarge tokio thread stack size for wasm Apr 1, 2026
@CPunisher CPunisher requested a review from hardfist April 1, 2026 06:51
@CPunisher CPunisher marked this pull request as ready for review April 1, 2026 06:51
@CPunisher CPunisher enabled auto-merge (squash) April 1, 2026 06:55
@CPunisher CPunisher marked this pull request as draft April 1, 2026 06:58
auto-merge was automatically disabled April 1, 2026 06:58

Pull request was converted to draft

@CPunisher CPunisher force-pushed the 03-31-chore/debug-wasm branch from c12abe5 to d0f4255 Compare April 1, 2026 10:18
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 1, 2026

Deploying rspack with  Cloudflare Pages  Cloudflare Pages

Latest commit: d0f4255
Status: ✅  Deploy successful!
Preview URL: https://f2cf7c70.rspack-v2.pages.dev
Branch Preview URL: https://03-31-chore-debug-wasm.rspack-v2.pages.dev

View logs

@CPunisher CPunisher force-pushed the 03-31-chore/debug-wasm branch from d0f4255 to ee6658a Compare April 1, 2026 10:50
@CPunisher CPunisher changed the title chore: enlarge tokio thread stack size for wasm chore: run @rspack/cli, @rspack/tests tests sequentially in wasm Apr 1, 2026
@CPunisher CPunisher marked this pull request as ready for review April 1, 2026 11:36
@CPunisher CPunisher enabled auto-merge (squash) April 1, 2026 11:42
@CPunisher CPunisher merged commit 0a7585a into main Apr 1, 2026
123 checks passed
@CPunisher CPunisher deleted the 03-31-chore/debug-wasm branch April 1, 2026 11:47
hardfist added a commit that referenced this pull request Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants