Skip to content

chore: switch codspeed official action#13582

Merged
CPunisher merged 2 commits intomainfrom
04-02-chore/codspeed
Apr 2, 2026
Merged

chore: switch codspeed official action#13582
CPunisher merged 2 commits intomainfrom
04-02-chore/codspeed

Conversation

@CPunisher
Copy link
Copy Markdown
Contributor

@CPunisher CPunisher commented Apr 2, 2026 •
edited
Loading

Summary

Codspeed 4.13.0 now supports --fair-sched with CODSPEED_EXPERIMENTAL_FAIR_SCHED or --experimental-fair-sched. So we can switch to the official release and action.

See: https://github.com/CodSpeedHQ/codspeed/releases/tag/v4.13.0

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CPunisher CPunisher requested a review from stormslowly as a code owner April 2, 2026 05:41
Copilot AI review requested due to automatic review settings April 2, 2026 05:41
@github-actions github-actions Bot added the team The issue/pr is created by the member of Rspack. label Apr 2, 2026
Copilot AI reviewed Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the Rust and binding benchmark workflows from a repo-local CodSpeed composite action to the official CodSpeed GitHub Action, leveraging CodSpeed runner v4.13.0’s new fair-scheduling support to stabilize benchmark execution.

Changes:

  • Switch benchmark workflows to use CodSpeedHQ/action@v4 instead of ./.github/actions/codspeed.
  • Enable fair scheduling via CODSPEED_EXPERIMENTAL_FAIR_SCHED in both benchmark workflows.
  • Bump the CodSpeed runner version from 4.12.1 to 4.13.0 in workflow inputs.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/bench-rust.yml Uses the official CodSpeed action for Rust benchmarks; enables fair scheduling and updates runner-version.
.github/workflows/bench-binding.yml Uses the official CodSpeed action for binding benchmarks; enables fair scheduling and updates runner-version.
.github/actions/codspeed/action.yaml Removes the custom composite CodSpeed action definition now that the official action is used.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/bench-rust.yml Outdated
Comment thread .github/workflows/bench-binding.yml Outdated
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 2, 2026 •
edited
Loading

Merging this PR will degrade performance by 2.77%

❌ 2 regressed benchmarks
✅ 14 untouched benchmarks
⏩ 19 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation rust@concatenate_module_code_generation 143.7 ms 145.8 ms -1.45%
❌ Simulation rust@create_chunk_ids 10.5 ms 10.8 ms -2.77%

Comparing 04-02-chore/codspeed (0c57799) with main (e723074)

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -
react-1k 826.3 KB -
react-5k 2.7 MB -
rome 984.2 KB -
ui-components 2.3 MB -
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 826.3 KB - -
📄 JavaScript 826.3 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 984.2 KB - -
📄 JavaScript 984.2 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.3 MB - -
📄 JavaScript 2.0 MB - -
🎨 CSS 271.6 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

📦 Binary Size-limit

Comparing 0c57799 to chore: run @rspack/cli, @rspack/tests tests sequentially in wasm (#13557) by CPunisher

🎉 Size decreased by 7.97KB from 49.09MB to 49.08MB (⬇️0.02%)

@CPunisher CPunisher enabled auto-merge (squash) April 2, 2026 06:36
@CPunisher CPunisher merged commit a6fc201 into main Apr 2, 2026
43 of 46 checks passed
@CPunisher CPunisher deleted the 04-02-chore/codspeed branch April 2, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@stormslowly stormslowly stormslowly approved these changes

Assignees

No one assigned

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CPunisher @stormslowly