Skip to content

ci: use contents:write permission for ecosystem CI commit comments#13611

Merged
fi3ework merged 1 commit intomainfrom
fix/ci-ecosystem-contents-write
Apr 3, 2026
Merged

ci: use contents:write permission for ecosystem CI commit comments#13611
fi3ework merged 1 commit intomainfrom
fix/ci-ecosystem-contents-write

Conversation

@fi3ework
Copy link
Copy Markdown
Member

@fi3ework fi3ework commented Apr 3, 2026 •
edited
Loading

Summary

fix the wrong config in #13605. the doc lied to us, AI was right.

  • createCommitComment is a POST (write) operation, so it requires contents: write permission, not contents: read
  • Fixes the 403 Resource not accessible by integration error in ecosystem CI per commit job

Test plan

  • Verify the ecosystem CI per commit job can successfully post commit comments after merge

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 [email protected]

@fi3ework @claude
fix(ci): use contents:write permission for ecosystem CI commit comments
dd3aaec 
`createCommitComment` is a write operation (POST) that requires
`contents: write`, not `contents: read`.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Copilot AI review requested due to automatic review settings April 3, 2026 14:25
@fi3ework fi3ework requested a review from stormslowly as a code owner April 3, 2026 14:25
@github-actions github-actions Bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Apr 3, 2026
@fi3ework fi3ework changed the title fix(ci): use contents:write permission for ecosystem CI commit comments ci: use contents:write permission for ecosystem CI commit comments Apr 3, 2026
@github-actions github-actions Bot removed the release: bug fix release: bug related release(mr only) label Apr 3, 2026
@fi3ework fi3ework enabled auto-merge (squash) April 3, 2026 14:27
Copilot AI reviewed Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions workflow permissions for the ecosystem_ci_per_commit job so it can successfully post commit comments (resolving the 403 Resource not accessible by integration failure seen in ecosystem CI per-commit runs).

Changes:

  • Change ecosystem_ci_per_commit job permission from contents: read to contents: write in CI workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 3, 2026 •
edited
Loading

Merging this PR will degrade performance by 1.3%

⚡ 2 improved benchmarks
❌ 2 regressed benchmarks
✅ 14 untouched benchmarks
⏩ 19 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation rust@concatenate_module_code_generation 142.8 ms 144.6 ms -1.26%
⚡ Simulation rust@persistent_cache_restore@basic-react-development 27 ms 26.4 ms +2.22%
⚡ Simulation rust@create_chunk_ids 10.8 ms 10.5 ms +2.73%
❌ Simulation rust@persistent_cache_restore_after_single_file_change@basic-react-development 27.5 ms 27.8 ms -1.3%

Comparing fix/ci-ecosystem-contents-write (dd3aaec) with main (9e48a3f)

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

Rsdoctor Bundle Diff Analysis

Found 6 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
popular-libs 1.7 MB 0
react-10k 5.7 MB 0
react-1k 826.2 KB 0
react-5k 2.7 MB 0
rome 984.1 KB 0
ui-components 5.0 MB 0

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

📦 Binary Size-limit

Comparing dd3aaec to chore(ci): add contents:read permission for ecosystem CI commit comments (#13605) by Max

🎉 Size decreased by 7.59KB from 49.26MB to 49.25MB (⬇️0.02%)

@fi3ework fi3ework merged commit c293c26 into main Apr 3, 2026
49 checks passed
@fi3ework fi3ework deleted the fix/ci-ecosystem-contents-write branch April 3, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@stormslowly stormslowly stormslowly approved these changes

Assignees

No one assigned

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fi3ework @stormslowly