Skip to content

chore: upgrade node to 24 while releasing#13639

Merged
chenjiahan merged 1 commit intomainfrom
chore/upgrade-release-node-version
Apr 8, 2026
Merged

chore: upgrade node to 24 while releasing#13639
chenjiahan merged 1 commit intomainfrom
chore/upgrade-release-node-version

Conversation

@LingyuCoder
Copy link
Copy Markdown
Contributor

@LingyuCoder LingyuCoder commented Apr 8, 2026

Summary

release failed because of promise-retry, seems that can be resolved by upgrading node to v24

see npm/cli#9151

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@LingyuCoder LingyuCoder requested a review from stormslowly as a code owner April 8, 2026 02:54
Copilot AI review requested due to automatic review settings April 8, 2026 02:54
@github-actions github-actions Bot added the team The issue/pr is created by the member of Rspack. label Apr 8, 2026
Copilot AI reviewed Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the npm release workflow to use Node.js 24 during publishing, aiming to avoid release failures related to the npm CLI promise-retry issue referenced in the PR description.

Changes:

  • Override the Node.js version used by the ./.github/actions/pnpm/setup composite action to 24 in the npm release job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

📦 Binary Size-limit

Comparing 5a33fcd to docs: update import for React Refresh plugin (#13632) by neverland

🎉 Size decreased by 8.34KB from 49.35MB to 49.34MB (⬇️0.02%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Rsdoctor Bundle Diff Analysis

Found 6 projects in monorepo, 6 projects with changes.

📊 Quick Summary
Project Total Size Change
popular-libs 1.7 MB -
react-10k 5.7 MB -
react-1k 826.9 KB -
rome 984.1 KB -
react-5k 2.7 MB -
ui-components 5.0 MB -
📋 Detailed Reports (Click to expand)

📁 popular-libs

Path: ../build-tools-performance/cases/popular-libs/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 1.7 MB - -
📄 JavaScript 1.7 MB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 826.9 KB - -
📄 JavaScript 826.9 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 984.1 KB - -
📄 JavaScript 984.1 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.0 MB - -
📄 JavaScript 4.7 MB - -
🎨 CSS 291.6 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@chenjiahan chenjiahan merged commit 6783130 into main Apr 8, 2026
37 checks passed
@chenjiahan chenjiahan deleted the chore/upgrade-release-node-version branch April 8, 2026 03:07
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 8, 2026 •
edited
Loading

Merging this PR will degrade performance by 1.11%

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 15 untouched benchmarks
⏩ 19 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation rust@persistent_cache_restore_after_single_file_change@basic-react-development 27.4 ms 27.7 ms -1.11%
⚡ Simulation rust@create_chunk_ids 10.9 ms 10.6 ms +2.88%
⚡ Simulation rust@concatenate_module_code_generation 149.6 ms 144.7 ms +3.37%

Comparing chore/upgrade-release-node-version (5a33fcd) with main (f15f7f4)

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

hardfist pushed a commit that referenced this pull request Apr 9, 2026
@LingyuCoder @hardfist
chore: upgrade node to 24 while releasing (#13639)
2cacbcd
@stormslowly stormslowly mentioned this pull request Apr 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@chenjiahan chenjiahan chenjiahan approved these changes

@stormslowly stormslowly Awaiting requested review from stormslowly stormslowly is a code owner

Assignees

No one assigned

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LingyuCoder @chenjiahan