Skip to content

docs(skills): clarify e2e rebuild ordering#1138

Merged
9aoy merged 1 commit intomainfrom
9aoy/docs-testing-skill-e2e-build-order
Apr 7, 2026
Merged

docs(skills): clarify e2e rebuild ordering#1138
9aoy merged 1 commit intomainfrom
9aoy/docs-testing-skill-e2e-build-order

Conversation

@9aoy
Copy link
Copy Markdown
Collaborator

@9aoy 9aoy commented Apr 3, 2026

Summary

Background

The testing skill did not explicitly warn against starting e2e before a workspace build had fully completed. That made it easy to hit missing built artifacts such as packages/core/dist/rstestSuppressWarnings.cjs during e2e runs.

Implementation

  • Added guidance to prefer pnpm build before e2e when a change can affect multiple packages.
  • Added explicit rules to wait for build completion, avoid overlapping build and e2e sessions, and treat missing built artifacts as incomplete-build failures.
  • Added a reminder to verify expected artifacts exist before retrying e2e when build completion is uncertain.

User Impact

Developers following the testing skill are less likely to trigger false e2e failures caused by incomplete package builds.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@9aoy 9aoy marked this pull request as ready for review April 3, 2026 08:22
@9aoy 9aoy merged commit 9e989af into main Apr 7, 2026
7 checks passed
@9aoy 9aoy deleted the 9aoy/docs-testing-skill-e2e-build-order branch April 7, 2026 02:56
@9aoy 9aoy mentioned this pull request Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant