Skip to content

fix(actions): better runtime check for invalid usages#12402

Merged
ematipico merged 2 commits intomainfrom
fix/astro-actions-error
Nov 8, 2024
Merged

fix(actions): better runtime check for invalid usages#12402
ematipico merged 2 commits intomainfrom
fix/astro-actions-error

Conversation

@ematipico
Copy link
Copy Markdown
Member

Changes

Closes #12393
Closes PLT-2625

The user code was invalid, but Astro didn't catch it. Now it does

Testing

Added a new test case

Docs

N/A

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 8, 2024

🦋 Changeset detected

Latest commit: 9264811

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 8, 2024
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Nov 8, 2024

CodSpeed Performance Report

Merging #12402 will not alter performance

Comparing fix/astro-actions-error (d3e0794) with main (f5f7109)

Summary

✅ 1 untouched benchmarks

Copy link
Copy Markdown
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check yourself before you wreck yourself

Comment thread packages/astro/test/actions.test.js
Comment thread packages/astro/src/actions/runtime/virtual/server.ts Outdated
@ematipico ematipico merged commit 823e73b into main Nov 8, 2024
@ematipico ematipico deleted the fix/astro-actions-error branch November 8, 2024 15:55
@astrobot-houston astrobot-houston mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Context not available in astro:actions

3 participants