Conversation
1241ce6 to
5498fdd
Compare
Signed-off-by: Henry Schreiner <[email protected]>
5498fdd to
0ba755d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates conda test configuration by centralizing conda marker handling in the test infrastructure. Instead of using scattered conditional skip decorators, it implements a unified pytest marker system that automatically manages conda test execution.
- Removed local
HAS_CONDAvariables andhas_condaskip decorators from individual test files - Added centralized conda marker configuration in
conftest.pywith automatic test discovery and skipping - Replaced
@has_condadecorators with@pytest.mark.condamarkers across test files
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_virtualenv.py | Removed local conda detection and replaced @has_conda decorators with @pytest.mark.conda markers |
| tests/test_sessions.py | Removed local conda detection and replaced @has_conda decorator reference with pytest.mark.conda marker |
| tests/conftest.py | Added centralized conda marker infrastructure with automatic test discovery and conda command blocking |
| pyproject.toml | Added conda marker definition to pytest configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
|
Looks fine, but what does the conda marker accomplish? |
|
This is an easier way to identify and potentially act on the conda tests. Most importantly, it means you can now skip the conda tests even if you have conda installed ( We can also now ensure that tests that call conda are marked (and therefore skipped), even if conda is installed on the developers machine. |
Adding a conda marker.