fix: Malformed ZIP64 file output (#715) by Its-Just-Nans · Pull Request #717 · zip-rs/zip2

Its-Just-Nans · 2026-03-09T16:33:25Z

Also fix the zip64 central directory creation and add a test

gemini-code-assist · 2026-03-09T16:33:44Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the handling of Zip64 extended information in central directory headers. It introduces a mechanism to explicitly mark files as 'large', ensuring that the necessary Zip64 fields are always written for them, regardless of their specific size values. This change improves the robustness and correctness of ZIP archive generation, particularly for files that might be logically large but have zero or small reported sizes under certain conditions.

Highlights

Zip64 Extended Information Logic: The central_header function in Zip64ExtendedInformation now accepts an is_large_file boolean parameter. This parameter explicitly signals whether a file should be treated as large, ensuring that Zip64 size fields are included even if the uncompressed_size or compressed_size are zero or below the ZIP64_BYTES_THR threshold.
Integration with File Writing: The write_central_directory_header function in write.rs has been updated to pass the file.large_file flag to the Zip64ExtendedInformation::central_header function, correctly propagating the large file status.

Changelog

src/extra_fields/zip64_extended_information.rs
- Modified the central_header function signature to include an is_large_file parameter.
- Adjusted the conditional logic for including uncompressed and compressed sizes in the Zip64 extended information based on the new is_large_file parameter.
src/write.rs
- Updated the call to Zip64ExtendedInformation::central_header to pass the file.large_file boolean argument.

Activity

No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

amazon-q-developer

The PR correctly adds the missing is_large_file parameter to Zip64ExtendedInformation::central_header() and updates the call site. The central_header function was already checking is_large_file in its logic (lines 80, 86) but the parameter wasn't being passed from the caller, which would have caused the condition to always be false. This fix ensures that files explicitly marked with large_file: true will consistently use ZIP64 extra fields in both local and central directory headers, even when file sizes are below the 4GiB threshold.

Note: The PR title should follow Conventional Commits format (e.g., "fix: add missing is_large_file parameter to central_header").

You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

gemini-code-assist

Code Review

The pull request introduces an is_large_file boolean parameter to the Zip64ExtendedInformation::central_header function. This parameter is now passed from the write_central_directory_header function and is used to explicitly include uncompressed and compressed sizes in the ZIP64 extended information block if a file is designated as large, even if its size does not exceed the ZIP64_BYTES_THR threshold.

Its-Just-Nans · 2026-03-09T21:40:16Z

@Pr0methean I think we should merge this

Or wait for a test

Or add the test later

Its-Just-Nans · 2026-03-10T01:29:23Z

I think https://github.com/zip-rs/zip2/pull/265/changes is not correct and
e86d376 not the best

Pr0methean

Could you please describe whatever issues this fixes in the title, link them in the description, and add a category to the title?

Pr0methean

Just a couple of nitpicks.

dimissing the review (fixed) to merge queue

Its-Just-Nans added 2 commits March 9, 2026 10:29

Update zip64_extended_information.rs

7202345

Update write.rs

8469128

amazon-q-developer bot reviewed Mar 9, 2026

View reviewed changes

Comment thread src/write.rs Outdated

Update zip64_extended_information.rs

bba7cd3

gemini-code-assist bot reviewed Mar 9, 2026

View reviewed changes

Its-Just-Nans added 3 commits March 9, 2026 10:39

Update zip64_extended_information.rs

95bebf7

Update types.rs

7b7b044

Update types.rs

c3d7eef

github-advanced-security AI found potential problems Mar 9, 2026

View reviewed changes

Comment thread src/types.rs Fixed

Comment thread src/types.rs Fixed

Comment thread src/types.rs Fixed

Comment thread src/types.rs Fixed

Comment thread src/types.rs Fixed

Comment thread src/types.rs Fixed

Its-Just-Nans added 3 commits March 9, 2026 11:12

Update types.rs

bde2d29

Update types.rs

d917e53

Update zip64_extended_information.rs

2a2957a

Its-Just-Nans self-assigned this Mar 9, 2026

Its-Just-Nans added 3 commits March 9, 2026 18:32

add byte by byte test

c15fb22

crazy function

8d0a70d

ofc

ba42e30

Its-Just-Nans commented Mar 10, 2026

View reviewed changes

Comment thread src/write.rs Outdated

Its-Just-Nans added 2 commits March 9, 2026 18:45

cargo fmt of the crazy function

b48424f

fix test multi feature

d838a9c

Its-Just-Nans added 4 commits March 9, 2026 19:31

remove incorrect code

527baff

comment for windows

adb1118

Trigger Build

9e31287

fix deep_copy

ddd6720

Its-Just-Nans requested a review from Pr0methean March 10, 2026 17:08

Pr0methean requested changes Mar 11, 2026

View reviewed changes

Comment thread src/extra_fields/zip64_extended_information.rs Outdated

Its-Just-Nans changed the title ~~Update zip64_extended_information.rs~~ fix: zip64 extended information Mar 11, 2026

fix code and comment tests

e6416bd

Pr0methean changed the title ~~fix: zip64 extended information~~ fix: Malformed ZIP64 file output (#715) Mar 11, 2026

Pr0methean previously requested changes Mar 11, 2026

View reviewed changes

Comment thread tests/zip64_large.rs Outdated

Comment thread tests/zip64_large.rs Outdated

update comment

08b4760

Its-Just-Nans requested a review from Pr0methean March 11, 2026 23:18

Merge branch 'master' into Its-Just-Nans-patch-1

b97f82a

Its-Just-Nans enabled auto-merge March 16, 2026 04:44

Its-Just-Nans added this pull request to the merge queue Mar 16, 2026

Merged via the queue into master with commit 859dc16 Mar 16, 2026
130 checks passed

Its-Just-Nans deleted the Its-Just-Nans-patch-1 branch March 16, 2026 07:45

This was referenced Mar 16, 2026

chore: release v8.3.0 #718

Closed

chore: release v8.3.0 #729

Merged

Its-Just-Nans mentioned this pull request Mar 18, 2026

refactor: remove zip64 extra field update #732

Merged

woodruffw mentioned this pull request Apr 10, 2026

Fix zip64 extended information field parsing for central directory entries astral-sh/rs-async-zip#32

Closed

Conversation

Its-Just-Nans commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Mar 9, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

amazon-q-developer bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Its-Just-Nans commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Its-Just-Nans commented Mar 10, 2026

Uh oh!

Pr0methean left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Pr0methean left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Its-Just-Nans commented Mar 9, 2026 •

edited

Loading

Its-Just-Nans commented Mar 9, 2026 •

edited

Loading

Pr0methean left a comment •

edited

Loading