Skip to content

Adding tag option to action#1142

Merged
JamesIves merged 8 commits intoJamesIves:devfrom
germa89:feat/Adding-tag-option
Jul 17, 2022
Merged

Adding tag option to action#1142
JamesIves merged 8 commits intoJamesIves:devfrom
germa89:feat/Adding-tag-option

Conversation

@germa89
Copy link
Copy Markdown
Contributor

@germa89 germa89 commented Jun 16, 2022 •
edited
Loading

Description

I found out that in some cases, pushing to the doc repo using a tag is convenient.

Testing Instructions

In theory, it should work by providing the key option tag.

- name: Deploy 🚀
  uses: JamesIves/[email protected]
  with:
    branch: gh-pages # The branch the action should deploy to.
    folder: build # The folder the action should deploy.
    tag: 'v0.1'

Additional Notes

@germa89 germa89 requested a review from JamesIves as a code owner June 16, 2022 06:26
@germa89 germa89 mentioned this pull request Jun 16, 2022
Closed
@JamesIves
Copy link
Copy Markdown
Owner

JamesIves commented Jun 17, 2022 •
edited
Loading

Thanks for the contribution. Do you mind creating an issue for this along with rationale so it can be tracked?

@germa89
Copy link
Copy Markdown
Contributor Author

germa89 commented Jun 17, 2022

Thanks for the contribution. Do you mind creating an issue for this along with rationale so it can be tracked?

Hi @JamesIves , done!

JamesIves
JamesIves reviewed Jun 22, 2022
View reviewed changes
Comment thread src/constants.ts Outdated
Comment thread README.md Outdated
@germa89
Copy link
Copy Markdown
Contributor Author

germa89 commented Jun 29, 2022

@JamesIves I have implemented the changes. Let me know if there is anything more I can do.

@JamesIves
Copy link
Copy Markdown
Owner

JamesIves commented Jul 4, 2022

Will get to this in the next couple of days, thanks for your patience!

@JamesIves
Copy link
Copy Markdown
Owner

JamesIves commented Jul 17, 2022

Looks good to me! Thanks for making the changes

@JamesIves JamesIves merged commit 079ec0e into JamesIves:dev Jul 17, 2022
@germa89 germa89 deleted the feat/Adding-tag-option branch July 18, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesIves JamesIves JamesIves left review comments

+2 more reviewers

@mgalloue mgalloue mgalloue approved these changes

@nmalsang nmalsang nmalsang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add tags to deployed commit

4 participants

@germa89 @JamesIves @mgalloue @nmalsang