fix: Handle existing RBAC role gracefully in namespace registry#6220
Open
jyejare wants to merge 1 commit intofeast-dev:masterfrom
Open
fix: Handle existing RBAC role gracefully in namespace registry#6220jyejare wants to merge 1 commit intofeast-dev:masterfrom
jyejare wants to merge 1 commit intofeast-dev:masterfrom
Conversation
Signed-off-by: Jitendra Yejare <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixed the "already exists" error when multiple FeatureStore instances try to create the same "feast-configs-registry-reader" Role. Changed from CreateOrUpdate to a check-then-create pattern to avoid conflicts when the shared Role already exists.
Which issue(s) this PR fixes:
Checks
git commit -s)Testing Strategy
Misc