feat: Phase 1 - Added different data modes to UI server#6223
Open
ntkathole wants to merge 1 commit intofeast-dev:masterfrom
Open
feat: Phase 1 - Added different data modes to UI server#6223ntkathole wants to merge 1 commit intofeast-dev:masterfrom
ntkathole wants to merge 1 commit intofeast-dev:masterfrom
Conversation
e678d5e to
0edf62e
Compare
Signed-off-by: ntkathole <[email protected]>
0edf62e to
92e790b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implements Phase 1 for #5411
Usage example:
Files Modified
sdk/python/feast/cli/ui.py- Added two new CLI options:--mode / -m: Accepts proto (default), rest, or rest-external
--rest-api-url: Required when using --mode=rest-external, specifies the external REST registry URL
Added validation: rest-external mode requires --rest-api-url
sdk/python/feast/feature_store.py- Updated serve_ui() method:Added mode and rest_api_url parameters, passed through to ui_server.start_server()
sdk/python/feast/ui_server.py- Rewritten with three mode-specific setup functions:Which issue(s) this PR fixes:
#5411
Checks
git commit -s)Testing Strategy