Skip to content

feat: Support podAnnotations on Deployment pod template#6225

Open
ntkathole wants to merge 1 commit intofeast-dev:masterfrom
ntkathole:annotate_template
Open

feat: Support podAnnotations on Deployment pod template#6225
ntkathole wants to merge 1 commit intofeast-dev:masterfrom
ntkathole:annotate_template

Conversation

@ntkathole
Copy link
Copy Markdown
Member

@ntkathole ntkathole commented Apr 4, 2026

What this PR does / why we need it:

Added a new PodAnnotations map[string]string field to the FeatureStoreServices struct, allowing users to declaratively set annotations on the Deployment's pod template. Users can now enable OpenTelemetry auto-instrumentation (or any annotation-driven integration) like this:

apiVersion: feast.dev/v1
kind: FeatureStore
metadata:
  name: my-feast
spec:
  services:
    podAnnotations:
      instrumentation.opentelemetry.io/inject-python: "true"
    onlineStore:
      server:
        metrics: true

Which issue(s) this PR fixes:

Fixes #6194

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Open with Devin

@ntkathole ntkathole self-assigned this Apr 4, 2026
@ntkathole ntkathole requested a review from a team as a code owner April 4, 2026 12:19
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support podAnnotations on Deployment pod template to enable OpenTelemetry auto-instrumentation

1 participant