Skip to content

Add cSpell to NUKE build pipeline#2086

Merged
dennisdoomen merged 19 commits intofluentassertions:developfrom
IT-VBFK:cspell-with-nuke
Jan 6, 2023
Merged

Add cSpell to NUKE build pipeline#2086
dennisdoomen merged 19 commits intofluentassertions:developfrom
IT-VBFK:cspell-with-nuke

Conversation

@IT-VBFK
Copy link
Copy Markdown
Contributor

@IT-VBFK IT-VBFK commented Jan 4, 2023 •
edited
Loading

This ref. and finishes #2017

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 4, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3856028965

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.984%
Totals Coverage Status
Change from base Build 3853478629: 0.0%
Covered Lines: 8525
Relevant Lines: 8768
💛 - Coveralls

IT-VBFK
IT-VBFK commented Jan 4, 2023
View reviewed changes
Comment thread Build/Build.cs Outdated
Comment thread Build/Build.cs Outdated
@IT-VBFK IT-VBFK marked this pull request as ready for review January 4, 2023 10:03
jnyrup
jnyrup reviewed Jan 4, 2023
View reviewed changes
Comment thread .github/workflows/spellcheck.yml Outdated
Comment thread .github/workflows/spellcheck.yml Outdated
@IT-VBFK IT-VBFK requested a review from jnyrup January 4, 2023 20:05
@IT-VBFK
Copy link
Copy Markdown
Contributor Author

IT-VBFK commented Jan 5, 2023

So.. now I cannot imagine how to move more steps to .NET 😆

@SeanKilleen SeanKilleen mentioned this pull request Jan 5, 2023
Closed
5 tasks
jnyrup
jnyrup reviewed Jan 5, 2023
View reviewed changes
Comment thread Build/Build.cs Outdated
dennisdoomen
dennisdoomen requested changes Jan 5, 2023
View reviewed changes
Comment thread .github/workflows/spellcheck.yml
Comment thread Build/Build.cs Outdated
Comment thread Build/Build.cs Outdated
@IT-VBFK IT-VBFK requested a review from dennisdoomen January 5, 2023 13:54
jnyrup
jnyrup reviewed Jan 5, 2023
View reviewed changes
Comment thread cSpell.json Outdated
Comment thread .github/workflows/spellcheck.yml
dennisdoomen
dennisdoomen approved these changes Jan 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

IT-VBFK
IT-VBFK commented Jan 6, 2023
View reviewed changes
Comment thread Build/Build.cs Outdated
@jnyrup
Copy link
Copy Markdown
Member

jnyrup commented Jan 6, 2023

I had a play with this, and here's my best attempt

Node($"{YarnCli} install --silent", workingDirectory: RootDirectory);
Node($"{YarnCli} --silent run cspell --no-summary", workingDirectory: RootDirectory,
    customLogger: (_, msg) => Error(msg));

Without spelling errors
image

With spelling errors
image

@IT-VBFK
Copy link
Copy Markdown
Contributor Author

IT-VBFK commented Jan 6, 2023 •
edited
Loading

That looks great.. Just changed it :)

Edit: Tried to make some mistakes.. I cannot get the target to fail? Why?

I changed Sometimes to Somtimes and Sometmies in docs/_pages/basicassertions.md

Edit2: This was an error in the code blocks regex pattern. Fixed that (and several spelling issues too) :D

This was referenced Oct 3, 2025
Closed
Closed
@dependabot dependabot bot mentioned this pull request Oct 13, 2025
Closed
This was referenced Oct 20, 2025
Closed
Closed
Open
Open
This was referenced Oct 27, 2025
Closed
Closed
This was referenced Nov 10, 2025
Closed
Closed
This was referenced Nov 24, 2025
Closed
Open
This was referenced Dec 1, 2025
Closed
Closed
Merged
Closed
This was referenced Dec 22, 2025
Open
Closed
This was referenced Jan 11, 2026
Merged
Open
@dependabot dependabot bot mentioned this pull request Feb 8, 2026
Merged
This was referenced Mar 2, 2026
Closed
Closed
@dependabot dependabot bot mentioned this pull request Mar 17, 2026
Open
This was referenced Mar 24, 2026
Closed
Merged
This was referenced Apr 3, 2026
Open
Closed
@dependabot dependabot bot mentioned this pull request Apr 15, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

building Building and Infrastructure of Fluent Assertions documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IT-VBFK @coveralls @jnyrup @dennisdoomen @SeanKilleen