Skip to content

Clean up Build.cs#2093

Merged
jnyrup merged 16 commits intofluentassertions:developfrom
IT-VBFK:clean-up-build-file
Jan 14, 2023
Merged

Clean up Build.cs#2093
jnyrup merged 16 commits intofluentassertions:developfrom
IT-VBFK:clean-up-build-file

Conversation

@IT-VBFK
Copy link
Copy Markdown
Contributor

@IT-VBFK IT-VBFK commented Jan 9, 2023 •
edited
Loading

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

This PR does following

  • Switch to GitHubActions which will be injected by NUKE at build start
    • Therefore: Retire manually passed arguments/parameters
      • BranchSpec
      • BuildNumber
      • PullRequestBase
  • Rename ApiKey to more specific NuGetApiKey
  • Proceed with pipeline if spell check fails
  • Move related code as near as possible to each other
  • Clean up node commands

IT-VBFK
IT-VBFK commented Jan 9, 2023
View reviewed changes
Comment thread .github/workflows/build.yml
Comment thread Build/Build.cs Outdated
Comment thread Build/Build.cs
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 9, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3910411035

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 96.919%
Totals Coverage Status
Change from base Build 3892640345: 0.9%
Covered Lines: 12440
Relevant Lines: 12683
💛 - Coveralls

@IT-VBFK IT-VBFK force-pushed the clean-up-build-file branch 2 times, most recently from 4627950 to cbeb99c Compare January 9, 2023 18:37
@jnyrup jnyrup added the building Building and Infrastructure of Fluent Assertions label Jan 9, 2023
@IT-VBFK IT-VBFK force-pushed the clean-up-build-file branch from 8a2333c to 2b9f860 Compare January 9, 2023 18:51
@IT-VBFK
Copy link
Copy Markdown
Contributor Author

IT-VBFK commented Jan 10, 2023 •
edited
Loading

Waiting for #2094...

I will step by step adding migrations from the discussion.. so... I will make this a draft now, because it will take a little longer as expected :)

@IT-VBFK
Copy link
Copy Markdown
Contributor Author

IT-VBFK commented Jan 10, 2023

What about if we continue the pipeline, even if the spell check fails? @jnyrup or @dennisdoomen

@jnyrup
Copy link
Copy Markdown
Member

jnyrup commented Jan 10, 2023 •
edited
Loading

What about if we continue the pipeline, even if the spell check fails? @jnyrup or @dennisdoomen

Somehow I thought that was already how it worked since .\build.ps1 --plan shows them as disjoint.

But yes, SpellCheck and Push should preferably continue independently of each other.

@IT-VBFK
Copy link
Copy Markdown
Contributor Author

IT-VBFK commented Jan 10, 2023

This is a really tricky task..

I am checking now if I can overcome this issue

@jnyrup
Copy link
Copy Markdown
Member

jnyrup commented Jan 10, 2023

It seems we can simply use .ProceedAfterFailure() on both SpellCheck and Push.
image

@IT-VBFK
Copy link
Copy Markdown
Contributor Author

IT-VBFK commented Jan 10, 2023 •
edited
Loading

Oh... that's too easy.. 🙈

Checking now the other way round.. a second please

Edit: seems good :) take that solution 🎉

@IT-VBFK IT-VBFK force-pushed the clean-up-build-file branch from 2b9f860 to 3493738 Compare January 10, 2023 17:30
@IT-VBFK IT-VBFK marked this pull request as draft January 10, 2023 17:41
@IT-VBFK IT-VBFK force-pushed the clean-up-build-file branch from 232822d to 7943554 Compare January 10, 2023 21:42
IT-VBFK
IT-VBFK commented Jan 10, 2023
View reviewed changes
Comment thread Build/Build.cs Outdated
@IT-VBFK IT-VBFK force-pushed the clean-up-build-file branch 2 times, most recently from f4d01d5 to b1fadf1 Compare January 10, 2023 22:08
@IT-VBFK IT-VBFK changed the title Clean up Build.cs: Deduplicate code elements, remove dead code Clean up Build.cs: Deduplicate code elements, generating workflow yaml files Jan 10, 2023
dennisdoomen
dennisdoomen reviewed Jan 11, 2023
View reviewed changes
Comment thread Build/Build.cs Outdated
@IT-VBFK
Copy link
Copy Markdown
Contributor Author

IT-VBFK commented Jan 11, 2023

Ok.. just to make sure we are in sync here:
"The most changes": includes everything but the yaml generation?

@IT-VBFK IT-VBFK mentioned this pull request Jan 11, 2023
Merged
@dennisdoomen
Copy link
Copy Markdown
Member

dennisdoomen commented Jan 11, 2023 •
edited
Loading

Ok.. just to make sure we are in sync here:
"The most changes": includes everything but the yaml generation?

I quickly glanced at the PR and most seems legit, but we still need to do a thorough review.

@IT-VBFK IT-VBFK changed the title Clean up Build.cs: Deduplicate code elements, generating workflow yaml files Clean up Build.cs: Deduplicate code elements Jan 11, 2023
@IT-VBFK IT-VBFK force-pushed the clean-up-build-file branch 3 times, most recently from 03bdcc4 to 726319d Compare January 11, 2023 16:17
This was referenced Oct 3, 2025
Closed
Closed
@dependabot dependabot bot mentioned this pull request Oct 13, 2025
Closed
This was referenced Oct 20, 2025
Closed
Closed
Open
Open
This was referenced Oct 27, 2025
Closed
Closed
This was referenced Nov 10, 2025
Closed
Closed
This was referenced Nov 24, 2025
Closed
Open
This was referenced Dec 1, 2025
Closed
Closed
Merged
Closed
This was referenced Dec 22, 2025
Open
Closed
This was referenced Jan 11, 2026
Merged
Open
@dependabot dependabot bot mentioned this pull request Feb 8, 2026
Merged
This was referenced Mar 2, 2026
Closed
Closed
@dependabot dependabot bot mentioned this pull request Mar 17, 2026
Open
This was referenced Mar 24, 2026
Closed
Merged
This was referenced Apr 3, 2026
Open
Closed
@dependabot dependabot bot mentioned this pull request Apr 15, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

+1 more reviewer

@ITaluone ITaluone ITaluone left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

building Building and Infrastructure of Fluent Assertions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IT-VBFK @coveralls @jnyrup @dennisdoomen @ITaluone