fix(expect): remove @types/node from dependencies#14385
fix(expect): remove @types/node from dependencies#14385SimenB merged 3 commits intojestjs:mainfrom dmitri-gb:remove-types-node-from-expect
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
| currentConcurrentTestName?: AsyncLocalStorage<string>; | ||
| currentConcurrentTestName?: () => string | undefined; |
There was a problem hiding this comment.
Looks like breaking change, or?
There was a problem hiding this comment.
yes. Not sure if it's breaking enough, tho... 😅
There was a problem hiding this comment.
Well, breaking for anyone that calls jestExpect.setState with this property or anyone that reads it inside a custom matcher. Since the property was only added in v29.6.0 then I'm pretty sure only Jest itself does that 😅
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Remove
@types/nodefrom dependencies ofexpect. This package can be used in non-Node.js environments.The dependency was introduced in #14139.