fix: symbol key could not be enum.#14414
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
mrazauskas
left a comment
There was a problem hiding this comment.
Thanks. I left a couple of comments.
Also rebase the branch, please. The lint error should go away.
|
Thanks. Implementation looks good. Please consider #14414 (comment) The thing is that writing e2e tests for all the use cases of asymmetric matchers would create too many files. In this case unit tests are sufficient. They allow creating lots of test cases easily. For example, did you consider adding a negative test? Keep in mind that |
Ok, thank you. I will fix it later |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fix: #14308
Test plan
Test at local.
e2e/__tests__/symbolKey.test.ts ✓ run test with symbol key (297 ms) Test Suites: 1 passed, 1 total Tests: 1 passed, 1 total Snapshots: 1 passed, 1 total Time: 0.596 s, estimated 1 s