Skip to content

Fix: use named exports only for ESM build#2226

Merged
styfle merged 1 commit intomarkedjs:masterfrom
benmccann:esm-entry
Oct 7, 2021
Merged

Fix: use named exports only for ESM build#2226
styfle merged 1 commit intomarkedjs:masterfrom
benmccann:esm-entry

Conversation

@benmccann
Copy link
Copy Markdown
Contributor

@benmccann benmccann commented Oct 6, 2021

Marked version: 3.0.6

Markdown flavor: all

Description

Expectation

UMD build should have only default export for backwards compatibility. CJS cannot have both named and default exports like ESM can

Result

Backwards compatibility broke in UMD build

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 6, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/7hqcLD8XkkvDd67KoNgefVcPbU9B
✅ Preview: https://markedjs-git-fork-benmccann-esm-entry-markedjs.vercel.app

This was referenced Oct 6, 2021
Closed
Merged
UziTech
UziTech approved these changes Oct 7, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

@benmccann
Copy link
Copy Markdown
Contributor Author

benmccann commented Oct 7, 2021

No problem. Sorry I broke things

@UziTech
Copy link
Copy Markdown
Member

UziTech commented Oct 7, 2021

Happens to all of us ☺️

@ddolcimascolo
Copy link
Copy Markdown

ddolcimascolo commented Oct 7, 2021

Hi guys, do you plan to release a patched version soon?

Thx,
David

@styfle styfle merged commit 223e61d into markedjs:master Oct 7, 2021
@benmccann benmccann mentioned this pull request Oct 7, 2021
Closed
5 tasks
@RomanHotsiy
Copy link
Copy Markdown
Contributor

RomanHotsiy commented Oct 7, 2021 •
edited
Loading

@UziTech @styfle could you please cut a new release 🙏. This breaks our customer builds.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 7, 2021

🎉 This PR is included in version 3.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon mentioned this pull request Oct 7, 2021
Closed
@ddolcimascolo
Copy link
Copy Markdown

ddolcimascolo commented Oct 7, 2021

Thx

This was referenced Sep 12, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UziTech UziTech UziTech approved these changes

@styfle styfle styfle approved these changes

@calculuschild calculuschild Awaiting requested review from calculuschild

Assignees

No one assigned

Labels

hacktoberfest-accepted released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benmccann @UziTech @ddolcimascolo @RomanHotsiy @styfle