Add check in splitCells to prevent calling trim on undefined#2372
Merged
UziTech merged 1 commit intomarkedjs:masterfrom Jan 27, 2022
Merged
Add check in splitCells to prevent calling trim on undefined#2372UziTech merged 1 commit intomarkedjs:masterfrom
UziTech merged 1 commit intomarkedjs:masterfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/markedjs/markedjs/HduowmakdRbDXEJt9n5CzVx6maj2 |
calculuschild
approved these changes
Jan 27, 2022
|
🎉 This PR is included in version 4.0.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked version: 4.0.11
Markdown flavor: GitHub Flavored Markdown
Description
Fixes #2371
Expectation
With this change I expect the example given in the issue to not cause a JavaScript error.
Result
The test case no longer throws an error and instead renders the table properly.
What was attempted
This PR adds a simple check to the
splitCellshelper function that validates that thecellsarray isn't empty before callingcells[cells.length - 1].trim(). This prevents the error "Cannot read properties of undefined (reading 'trim')" from being thrown.Contributor
Committer
In most cases, this should be a different person than the contributor.