Add connectTimeout configuration option OtlpGrpc{Signal}Exporters#6079
Merged
jkwatson merged 2 commits intoopen-telemetry:mainfrom Feb 24, 2024
Merged
Add connectTimeout configuration option OtlpGrpc{Signal}Exporters#6079jkwatson merged 2 commits intoopen-telemetry:mainfrom
jkwatson merged 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6079 +/- ##
=========================================
Coverage 91.06% 91.06%
- Complexity 5671 5678 +7
=========================================
Files 620 620
Lines 16553 16577 +24
Branches 1689 1692 +3
=========================================
+ Hits 15074 15096 +22
+ Misses 993 992 -1
- Partials 486 489 +3 ☔ View full report in Codecov by Sentry. |
…y-java into otlp-grpc-connect-timeout
Member
Author
|
@open-telemetry/java-approvers PTAL. This should be straight forward to review / merge. |
breedx-splk
approved these changes
Feb 20, 2024
Contributor
breedx-splk
left a comment
There was a problem hiding this comment.
Apologies on the time taken to get to reviewing this. 😓
This seems like a very welcome addition....kinda surprising it hasn't been more often requested tbh. Just had the one question about zero, but looks good otherwise.
jkwatson
approved these changes
Feb 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #5941 which adds support for OTLP gRPC exporters.